improve expr float() and int() to handle strings #161

fatpat · 2024-12-30T08:54:38Z

try to better handle string to int and string to float in expressions

hikhvar · 2024-12-31T21:23:08Z

pkg/metrics/parser.go

+	case string:
+		value, err := strconv.ParseInt(v, 10, 64)
+		if err != nil {
+			panic(err)


I'm not confident that we want to panic here. It's user supplied data after all. So a single malformed MQTT message will bring the exporter into a crashloop? 🤔

improve expr float() and int() to handle strings

e18dc0b

This was referenced Dec 30, 2024

add raw_expression #162

Merged

make error_value global to metric and add error_expression #157

Merged

hikhvar reviewed Dec 31, 2024

View reviewed changes

hikhvar merged commit 6bd07d1 into hikhvar:master Dec 31, 2024
15 of 16 checks passed

fatpat deleted the expr_int/float branch January 1, 2025 06:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve expr float() and int() to handle strings #161

improve expr float() and int() to handle strings #161

fatpat commented Dec 30, 2024 •

edited

Loading

hikhvar Dec 31, 2024

improve expr float() and int() to handle strings #161

improve expr float() and int() to handle strings #161

Conversation

fatpat commented Dec 30, 2024 • edited Loading

hikhvar Dec 31, 2024

Choose a reason for hiding this comment

fatpat commented Dec 30, 2024 •

edited

Loading